Re: PSQL - improve tab completion for pub/sub options - Mailing list pgsql-hackers

From Hüseyin Demir
Subject Re: PSQL - improve tab completion for pub/sub options
Date
Msg-id CAB5wL7bz_7_R0VmsKi+wtHMbkJ0UFAtu-4x8zbjGcYwYWUz+CA@mail.gmail.com
Whole thread
In response to PSQL - improve tab completion for pub/sub options  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
> --> but MatchAnyN is not compatible with HeadMatches
> --> need to use Matches
> --> but Matches cannot work, because logic needs needs HeadMatches
> ;-(
>
> ~~
>
> I've experimented with other things like:
>
> else if (Matches("CREATE", "PUBLICATION", MatchAny, MatchAnyN, "WITH", "(*") ||
>   Matches("CREATE", "PUBLICATION", MatchAny, MatchAnyN, "WITH", "(", MatchAnyN))
>
> ... but, apparently the Matches() logic only recognizes the first MatchAnyN.
>
> To cut a long story short, the only approach that I found that works
> was the `seen_with` scan.

Thank you for shedding light on this.

v4 LGTM. If no barring objections marked this patch as ready for committer.

Regards,
Demir.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Disallow outer-level and WHERE-clause aggregates in GRAPH_TABLE
Next
From: Peter Geoghegan
Date:
Subject: Re: RI fast path gets cross-type foreign keys wrong