Re: Checkpoint replication slots later - Mailing list pgsql-hackers

From Hüseyin Demir
Subject Re: Checkpoint replication slots later
Date
Msg-id CAB5wL7YVvOKPp-=Gs-QbKRhQiRSn5nj35F=ti61L1EA_L3bQmQ@mail.gmail.com
Whole thread
In response to Re: Checkpoint replication slots later  (Hüseyin Demir <huseyin.d3r@gmail.com>)
List pgsql-hackers


> I revisited the CheckPointSnapBuild() and
> CheckPointLogicalRewriteHeap(). Both functions work idempotently and
> are safe to move after CheckPointReplicationSlots(). They benefit from
> the updated last_saved_restart_lsn computed in the current checkpoint
> cycle, enabling more accurate cleanup decisions.
>
> I ran regression testing comparing the baseline (master) version with
> the patched version:
>
> - Checkpoint duration: No change.
> - WAL retention: More accurate, because it uses the current
> replication slot state.
> - Regressions: None detected.
> - Dependencies: No new dependencies introduced.
>
> Please see the v2 as attached but we can also commit the v1  since the
> only difference is the order of CheckPointSnapBuild and
> CheckPointLogicalRewriteHeap working idempotently.

Rebased it against the head.


Regards,
Demir.
Attachment

pgsql-hackers by date:

Previous
From: "ZizhuanLiu X-MAN"
Date:
Subject: Re: support create index on virtual generated column.
Next
From: Hüseyin Demir
Date:
Subject: Re: [PATCH] pg_upgrade: add --initdb option to create the new cluster automatically