Re: Add documentation for PG_ABS_SRCDIR, PG_ABS_BUILDDIR, PG_LIBDIR, PG_DLSUFFIX - Mailing list pgsql-hackers

From zhanghu
Subject Re: Add documentation for PG_ABS_SRCDIR, PG_ABS_BUILDDIR, PG_LIBDIR, PG_DLSUFFIX
Date
Msg-id CAB5m2Qt_jQ2UJNainsp+jhzjRS6rCPd5ti1MBwDoJnXXG2v_Vg@mail.gmail.com
Whole thread
In response to Add documentation for PG_ABS_SRCDIR, PG_ABS_BUILDDIR, PG_LIBDIR, PG_DLSUFFIX  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Add documentation for PG_ABS_SRCDIR, PG_ABS_BUILDDIR, PG_LIBDIR, PG_DLSUFFIX
List pgsql-hackers


Michael Paquier <michael@paquier.xyz> 于2026年3月11日周三 09:07写道:

>
> Hi all,
>
> d1029bb5a26c has switched the in-core tests suited based on pg_regress
> to do path substitutions based on the set of environment variables
> listed in $subject, rather than replacements based on input and output
> files, generating new files.
>
> These can be really useful for extension developers who maintain SQL
> test suites, so how about documenting them?
>
> I'd like to propose the attached patch, for HEAD, so as one does not
> need to guess their existence from the SQL files or pg_regress.c.
>
> Thoughts or comments?
> --
> Michael

Hi

The doc changes look good overall. I applied the patch locally and rendered the documentation to HTML, the new page also looks good.

A few minor nitpicks:

+       <para>
+        Name of extension for dynamically-loadable modules (e.g.
+        <literal>.so</literal> on Linux).
+       </para>

I think we need a "the" before "dynamically-loadable".

+      These are useful when dealing with function and object loading
+      that require specific paths to work, like paths defined in a
+      <command>CREATE FUNCTION</command> or <command>LOAD</command>
+      command, for example.

The ending "for example" sounds redundant, since "like" already conveys the meaning of "for example".

Best regards,
Zhang Hu

pgsql-hackers by date:

Previous
From: Shinya Kato
Date:
Subject: Re: pg_stat_replication.*_lag sometimes shows NULL during active replication
Next
From: shveta malik
Date:
Subject: Re: Skipping schema changes in publication