Re: Fix a couple of typos in JIT - Mailing list pgsql-hackers

From David Rowley
Subject Re: Fix a couple of typos in JIT
Date
Msg-id CAApHDvrFH5juxptZBVSGy1HWQOxa8_JwBq1GnDhdbavnid71Ug@mail.gmail.com
Whole thread Raw
In response to Re: Fix a couple of typos in JIT  (Abhijit Menon-Sen <ams@toroid.org>)
Responses Re: Fix a couple of typos in JIT  (Abhijit Menon-Sen <ams@toroid.org>)
List pgsql-hackers
On Thu, 20 Aug 2020 at 22:29, Abhijit Menon-Sen <ams@toroid.org> wrote:
>
> At 2020-08-20 22:19:49 +1200, dgrowleyml@gmail.com wrote:
> >
> > I was just looking over the JIT code and noticed a few comment and
> > documentation typos.  The attached fixes them.
>
> The first change does not seem to be correct:
>
> -That this is done at query execution time, possibly even only in cases
> -where the relevant task is done a number of times, makes it JIT,
> -rather than ahead-of-time (AOT). Given the way JIT compilation is used
> -in PostgreSQL, the lines between interpretation, AOT and JIT are
> -somewhat blurry.
> +This is done at query execution time, possibly even only in cases where
> +the relevant task is done a number of times, makes it JIT, rather than
> +ahead-of-time (AOT). Given the way JIT compilation is used in PostgreSQL,
> +the lines between interpretation, AOT and JIT are somewhat blurry.
>
> The original sentence may not be the most shining example of
> sentence-ry, but it is correct, and removing the "That" breaks it.

Oh, I see. I missed that. Perhaps it would be better changed to "The
fact that this"

David



pgsql-hackers by date:

Previous
From: Abhijit Menon-Sen
Date:
Subject: Re: Fix a couple of typos in JIT
Next
From: Fujii Masao
Date:
Subject: Re: New statistics for tuning WAL buffer size