Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options - Mailing list pgsql-hackers

From David Rowley
Subject Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Date
Msg-id CAApHDvqyCEGc7taz3OiF-LMsWmUVhgmGErWR9rH+wtFU-U-JCg@mail.gmail.com
Whole thread Raw
In response to Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options  (Tatsuo Ishii <ishii@postgresql.org>)
Responses Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
List pgsql-hackers
On Mon, 20 Oct 2025 at 16:59, Tatsuo Ishii <ishii@postgresql.org> wrote:
>
> > A very trivial commit:
> >
> > ```
> > +     else
> > +
> > +             /*
> > +              * For other cases we have no idea what position of row callers would
> > +              * fetch next time. Also for relpos < 0 case (we go backward), we
> > +              * cannot set mark either. For those cases we always set mark at 0.
> > +              */
> > +             mark_pos = 0;
> > ```
> >
> > The empty line after “else” is not needed.
>
> That was added by pgindent.

If it's written down somewhere, I can't find it, but the rule we
normally follow here is; don't use braces if the code block has a
single statement without any comments that appear on a separate line.
Otherwise, use braces.

Since your comments are not on the same line as the statement, it
should have braces. I imagine that's why pgindent is "acting weird".

David



pgsql-hackers by date:

Previous
From: AIX PG user
Date:
Subject: Re: AIX support
Next
From: Masahiko Sawada
Date:
Subject: Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue