Re: Fix bogus use of "long" in aset.c - Mailing list pgsql-hackers

From David Rowley
Subject Re: Fix bogus use of "long" in aset.c
Date
Msg-id CAApHDvqRGxd9H8OZHvArZ3t-CDXcxr9uBXHwwx+0+BAOWDmdqA@mail.gmail.com
Whole thread Raw
In response to Re: Fix bogus use of "long" in aset.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, 30 Oct 2025 at 13:24, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > The reason I left it an unsigned type was that the check is doing: if
> > (chsize + ALLOC_CHUNKHDRSZ != blk_used), so we'd still catch this with
> > an unsigned type, even if it wrapped due to going negative due to a
> > bogus freeptr. Changing to a signed type would leave us with a few
> > tests comparing signed to unsigned types.
>
> Yeah, that's fair.  I'm content with what you have.

Thanks for the reviews. I've pushed and backpatched to 13.

David



pgsql-hackers by date:

Previous
From: Arne Roland
Date:
Subject: Re: apply_scanjoin_target_to_paths and partitionwise join
Next
From: Chao Li
Date:
Subject: Re: tuple radix sort