Re: apply worker misses closing partition leaves - Mailing list pgsql-hackers

From David Rowley
Subject Re: apply worker misses closing partition leaves
Date
Msg-id CAApHDvqNAoDiE5-JgdXktvFkZ5VW0jn9BEQybrcifj=_J=Kh6Q@mail.gmail.com
Whole thread
In response to apply worker misses closing partition leaves  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
Responses Re: [PATCH] Add hook for plugins to acquire sample rows during ANALYZE
List pgsql-hackers
On Mon, 24 Aug 2026 at 22:33, Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
> The fix looks good to me. I just noticed one nit in the test:
>
> +       ok(!$node->log_contains(qr/resource was not closed/),
> +               'unclosed resources on ' . $node->name);
>
> I think the test message should be: "no unclosed resources on".

Sorry, I must be missing something here. You want the message that
complains when there *is* a resource leak WARNING say "no unclosed
resources on $server"?

Maybe if that message is confusing, then it might be better to write
"resource leak detected on $server".  Is that any better?

David



Attachment

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Assertion failure in GetSubscriptionRelations() with concurrent DROP TABLE
Next
From: Dilip Kumar
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication