Re: Printing window function OVER clauses in EXPLAIN - Mailing list pgsql-hackers

From David Rowley
Subject Re: Printing window function OVER clauses in EXPLAIN
Date
Msg-id CAApHDvpepuvR5jDq0rH_KzKbTA6+LuSWOgWG2thFDwvtnjyk_w@mail.gmail.com
Whole thread Raw
In response to Re: Printing window function OVER clauses in EXPLAIN  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Printing window function OVER clauses in EXPLAIN
List pgsql-hackers
On Tue, 11 Mar 2025 at 05:18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Here's a hopefully-final v3 that makes the two changes discussed.
> Now with a draft commit message, too.

Looks good to me.

The only minor points I noted down while reviewing were 1)
name_active_windows()'s newname variable could be halved in size and,
2) explain.sql's new test could name the window "w1" instead of "w" to
exercise the name selection code a bit better. Both are minor points,
but I thought I'd mention them anyway.

David



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Memory context can be its own parent and child in replication command
Next
From: Peter Smith
Date:
Subject: Tidy recent code bloat in pg_creatersubscriber::cleanup_objects_atexit