Re: Some clean-up work in get_cheapest_group_keys_order() - Mailing list pgsql-hackers

From David Rowley
Subject Re: Some clean-up work in get_cheapest_group_keys_order()
Date
Msg-id CAApHDvpct9sJA7Rc28AOR2vyqbzJLyFRaVXeeT+9S6h2NOR4tg@mail.gmail.com
Whole thread Raw
In response to Re: Some clean-up work in get_cheapest_group_keys_order()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Some clean-up work in get_cheapest_group_keys_order()
List pgsql-hackers
On Wed, 13 Jul 2022 at 11:02, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > * I think list_truncate(list_copy(list), n) is a pretty bad way to
> > copy the first n elements of a list, especially when n is likely to be
> > 0 most of the time. I think we should just add a function called
> > list_copy_head(). We already have list_copy_tail().
>
> Agreed, but I think there are other instances of that idiom that
> should be cleaned up while you're at it.

Agreed.  I imagine we should just do the remaining cleanup in master
only. Do you agree?

David



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns
Next
From: Michael Paquier
Date:
Subject: Re: test_oat_hooks bug (was: Re: pgsql: Add copy/equal support for XID lists)