Re: Speeding Up Bitmapset - Mailing list pgsql-hackers

From David Rowley
Subject Re: Speeding Up Bitmapset
Date
Msg-id CAApHDvpaWoT+Nx0iMaJ2rbD1eYx2J66Urs4=jQQg=CX32pFfHQ@mail.gmail.com
Whole thread Raw
In response to Re: Speeding Up Bitmapset  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
On Mon, 26 Jun 2023 at 12:55, Ranier Vilela <ranier.vf@gmail.com> wrote:
>
> Em dom., 25 de jun. de 2023 às 17:49, David Rowley <dgrowleyml@gmail.com> escreveu:
>>
>> There's no reason in the world
>> that those will speed up Bitmapsets, so why include them?
>
> Of course optimization is the most important thing,
> but since you're going to touch the source, why not make it more readable.

Have a look at [1]. In particular "Reasons your patch might be
returned" and precisely "Reformatting lines that haven't changed"

That entire page is quite valuable and I'd recommend having a read of all of it.

David

[1] https://wiki.postgresql.org/wiki/Submitting_a_Patch



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Assert while autovacuum was executing
Next
From: "Drouvot, Bertrand"
Date:
Subject: Re: Synchronizing slots from primary to standby