Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail. - Mailing list pgsql-hackers

From David Rowley
Subject Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail.
Date
Msg-id CAApHDvpKZYKpkFFzV-6FfqHd4TjufzeEGZh_04U9mCM_2E9WHw@mail.gmail.com
Whole thread Raw
In response to Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail.  (Richard Guo <guofenglinux@gmail.com>)
List pgsql-hackers
On Tue, 7 May 2024 at 16:47, Richard Guo <guofenglinux@gmail.com> wrote:
> --- a/src/backend/optimizer/plan/initsplan.c
> +++ b/src/backend/optimizer/plan/initsplan.c
> @@ -1888,7 +1888,7 @@ deconstruct_distribute_oj_quals(PlannerInfo *root,
>     qualscope = bms_union(sjinfo->syn_lefthand, sjinfo->syn_righthand);
>     qualscope = bms_add_member(qualscope, sjinfo->ojrelid);
>     ojscope = bms_union(sjinfo->min_lefthand, sjinfo->min_righthand);
> -   nonnullable_rels = sjinfo->syn_lefthand;
> +   nonnullable_rels = bms_copy(sjinfo->syn_lefthand);

I was busy looking at this too and I came to the same conclusion.

David



pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail.
Next
From: Tom Lane
Date:
Subject: Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail.