Re: Fix wrong filename in header comment of gin_tuple.h - Mailing list pgsql-hackers

From David Rowley
Subject Re: Fix wrong filename in header comment of gin_tuple.h
Date
Msg-id CAApHDvpCd_YkeBs2U1q1bTv2PEy9j4+FrEc_qZXLhNR2s8pS2Q@mail.gmail.com
Whole thread Raw
In response to Re: Fix wrong filename in header comment of gin_tuple.h  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
On Tue, 23 Sept 2025 at 10:21, Chao Li <li.evan.chao@gmail.com> wrote:
> My script just scan all .c and .h files and extract one-line filename and file path from header comments. If they
don’tequal to either pure filename or file path relative to repo root, then capture it. And rowsecurity.c was the only
capture,so I thought the filename part (“rewrite/rowsecurity.c) was a problem. When I made the fix, I added
“IDENTIFICATION”because I saw a lot of other files having it, but my script didn’t check “IDENTIFICATION”. 

Thanks for explaining that.

> I don’t insist to push this patch if you don’t consider the filename part is a problem.

I don't, personally. But will defer to anyone who thinks it's more of
an issue than I do.

David



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Fix overflow of nbatch
Next
From: Fujii Masao
Date:
Subject: Re: Trivial fix for comment of function table_tuple_lock