Re: Remove useless GROUP BY columns considering unique index - Mailing list pgsql-hackers

From David Rowley
Subject Re: Remove useless GROUP BY columns considering unique index
Date
Msg-id CAApHDvouQQmCqTgSH=a1MqemC6pGGD0b7XZ35pozEN0-m7yPyA@mail.gmail.com
Whole thread Raw
In response to Re: Remove useless GROUP BY columns considering unique index  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Remove useless GROUP BY columns considering unique index
List pgsql-hackers
On Wed, 18 Sept 2024 at 19:28, Peter Eisentraut <peter@eisentraut.org> wrote:
>
> On 12.09.24 03:43, David Rowley wrote:
> > (Likely it could just look at pg_attribute.attnotnull instead)
>
> That won't work because you can't record dependencies on that.  (This is
> one of the reasons for cataloging not-null constraints as real constraints.)

I'm not seeing any need to record constraint dependencies for this
optimisation. It would be different for detecting functional
dependencies in a view using a unique constraint+not null constraints
for ungrouped columns, but that's not what this is. This is just a
planner optimisation. The plan can be invalidated by a relcache
invalidation, which will happen if someone does ALTER TABLE DROP NOT
NULL.

For reference, see 5b736e9cf.

David



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Remove useless GROUP BY columns considering unique index
Next
From: Peter Eisentraut
Date:
Subject: Re: Remove shadowed declaration warnings