Re: heapgettup() with NoMovementScanDirection unused in core? - Mailing list pgsql-hackers

From David Rowley
Subject Re: heapgettup() with NoMovementScanDirection unused in core?
Date
Msg-id CAApHDvosuiqhxLTTVabOwJ16wnHcpxzL_sNqwzo71h8i98zPXg@mail.gmail.com
Whole thread Raw
In response to Re: heapgettup() with NoMovementScanDirection unused in core?  (Melanie Plageman <melanieplageman@gmail.com>)
List pgsql-hackers
On Wed, 1 Feb 2023 at 03:02, Melanie Plageman <melanieplageman@gmail.com> wrote:
>
> On Tue, Jan 31, 2023 at 11:46:05PM +1300, David Rowley wrote:
> > Both can be easily fixed, so no need to submit another patch as far as
> > I'm concerned.
>
> I realized I forgot a commit message in the second version. Patch v1 has
> one.

I made a couple of other adjustments to the Asserts and comments and
pushed the result.

On further looking, I felt the Assert was better off done in
create_indexscan_plan() rather than make_index[only]scan(). I also put
the asserts in tableam.h and removed the heapam.c ones.  The rest was
just comment adjustments.

David



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Show various offset arrays for heap WAL records
Next
From: "Joel Jacobson"
Date:
Subject: Re: [PATCH] Fix old thinko in formula to compute sweight in numeric_sqrt().