Request a Demo
Home   >   mailing lists

Re: Statistics Import and Export - Mailing list pgsql-hackers

From Hari Krishna Sunder
Subject Re: Statistics Import and Export
Date
Msg-id CAAeiqZ38ALsGyDF--qdoDC6wPGfbeOGioZO0EWVH8uJMeHDHAg@mail.gmail.com
Whole thread Raw
In response to Re: Statistics Import and Export  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Tree view
Sorry didn't know about the conference.

I think it would be better to revert 9879105 since there can be a considerable number of true empty tables that we don’t need to process.

---
Hari Krishna Sunder


On Mon, May 19, 2025 at 9:51 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
On Wed, May 14, 2025 at 01:30:48PM -0700, Hari Krishna Sunder wrote:
> Here is the patch with a comment.

Thanks.

> On Wed, May 14, 2025 at 8:53 AM Nathan Bossart <nathandbossart@gmail.com>
> wrote:
>> There was a similar report for vacuumdb's new --missing-stats-only option.
>> We fixed that in commit 9879105 by removing the check for reltuples != 0,
>> which means that --missing-stats-only will process empty tables.

I'm wondering if we should revert commit 9879105 if we take this change,
which solves the --missing-stats-only problem in a different way.  My
current thinking is that we should just leave it in place, if for no other
reason than analyzing some empty tables seems unlikely to cause too much
trouble.  Thoughts?

--
nathan

pgsql-hackers by date:

Previous
From: Nico Williams
Date:
Subject: Re: Should we optimize the `ORDER BY random() LIMIT x` case?
Next
From: Nathan Bossart
Date:
Subject: Re: regdatabase