Request a Demo
Home   >   mailing lists

Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions - Mailing list pgsql-hackers

From Sugamoto Shinya
Subject Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions
Date
Msg-id CAAe3y+_cJgyhWgSNQ8Xs83WDF6UsdgD57LboZ9jX+AcaAtX4eg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions
List pgsql-hackers
Tree view
On Wed, Nov 12, 2025 at 10:56 AM Fujii Masao <masao.fujii@gmail.com> wrote:
On Wed, Nov 12, 2025 at 10:10 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> +1 for hard-coding the supported encoding list. I think it's a good
> start point. We can revisit the idea of dynamically constructing the
> encoding list if we're concerned about its maintenance cost.

+1

Regards,

--
Fujii Masao

Thanks everyone for reviewing my proposal.
I've hard-coded the valid list of encoding names. 

Also, I modified the hint string into like "Valid encodings are \"hex\", \"base64\", \"base64url\", and \"escape\"."
by adding "and" before "escape".

I attached my v2 patch to this message. Please let me know freely if you have any additional questions.

Regards,
Attachment

pgsql-hackers by date:

Previous
From: Григорий Новиков
Date:
Subject: [PATCH] Add cascade synchronous replication
Next
From: "Matheus Alcantara"
Date:
Subject: Re: Include extension path on pg_available_extensions