[PATCH] Add error hints for invalid COPY options - Mailing list pgsql-hackers

From Sugamoto Shinya
Subject [PATCH] Add error hints for invalid COPY options
Date
Msg-id CAAe3y+816W-mRg=QH1fzdD7ouyhGv+FgREvfbhv4R8Tr1PU8kg@mail.gmail.com
Whole thread Raw
Responses Re: [PATCH] Add error hints for invalid COPY options
List pgsql-hackers
Hi,

This patch improves the user experience when working with COPY commands by
adding helpful error hints for invalid options.

Currently, when users make typos in COPY option names or values, they receive
a generic error message without guidance on what went wrong. This patch adds
two types of hints:

1. For invalid option names: suggests the closest matching valid option using
   the ClosestMatch algorithm (e.g., "foramt" → "Perhaps you meant 'format'")

2. For invalid option values: lists all valid values when the set is small
   (e.g., for format, on_error, log_verbosity options)

This follows the pattern already used elsewhere in PostgreSQL for providing
helpful error hints to users.

Additionally, this patch corrects a misleading comment for the
convert_selectively option. The comment stated it was "not-accessible-from-SQL",
but actualy it has been accessible from SQL due to PostgreSQL's generic option parser.
The updated comment clarifies that while technically accessible, it's intended for
internal use and not recommended for end-user use due to potential data loss.

Best regards,
Attachment

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Remove unused fields from BufferCacheNumaRec
Next
From: Michael Paquier
Date:
Subject: Re: Remove unused fields from BufferCacheNumaRec