Shruthi Gowda <gowdashru@gmail.com> writes: > The ECPG application crashes with a segmentation fault when calling > specific deallocation or prepared statement functions without an > established database connection. This is caused by a missing NULL check on > the connection handle before attempting to access it.
Hmm ... poking around, I see several other places that aren't checking the result of ecpg_get_connection. Shouldn't we tighten them all?
regards, tom lane
I agree. I’ve reviewed all occurrences of ecpg_get_connection() and noted that, in most instances, it is followed by ecpg_init(), which validates the connection and returns immediately if the connection is NULL.
In a few cases, the caller had already validated the connection. However, I identified an additional case that lacked this check, so I have revised the patch to include the missing validation.
