Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] pg_dump: Sort overloaded functions in deterministic order - Mailing list pgsql-hackers

From Joel Jacobson
Subject Re: [PATCH] pg_dump: Sort overloaded functions in deterministic order
Date
Msg-id CAASwCXdHAn72bYusMF0CjC4Zr=H+ExdFCd1tSph3cb24Tefo4w@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] pg_dump: Sort overloaded functions in deterministic order  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] pg_dump: Sort overloaded functions in deterministic order
List pgsql-hackers
Tree view
On Thu, Jul 5, 2012 at 10:33 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
You may in fact need a new field --- I'm just saying it should be in the
object-type-specific struct, eg FuncInfo, not DumpableObject.

I suggest adding char *funcsig to FuncInfo, and moving the "funcsig = format_function_arguments(finfo, funciargs)" code from dumpFunc to getFuncs.

Because dumpFunc is called after sortDumpableObjectsByTypeName, setting funcsig in the FuncInfo struct in dumpFunc would't work, as it needs to be available when entering sortDumpableObjectsByTypeName.

What do you think?

pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: Event Triggers reduced, v1
Next
From: Dimitri Fontaine
Date:
Subject: Re: Schema version management