Re: Cleanup isolation specs from unused steps - Mailing list pgsql-hackers

From Melanie Plageman
Subject Re: Cleanup isolation specs from unused steps
Date
Msg-id CAAKRu_bpApP_9FQgUeKbuEJBPf8+P1RP=Rx7HjGCcE64T7nx2g@mail.gmail.com
Whole thread Raw
In response to Cleanup isolation specs from unused steps  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Cleanup isolation specs from unused steps  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers

On Mon, Aug 19, 2019 at 1:08 AM Michael Paquier <michael@paquier.xyz> wrote:
Hi all,

I have been looking at the isolation tests, and we have in some specs
steps which are defined but not used in any permutations.  In order to
detect them, I have been using the attached trick to track which
permutations are used.  This allows to find immediately any
over-engineered spec by generating diffs about steps defined by not
used in any permutations.  On HEAD, we have six specs entering in this
category.

Would that be useful?

I think it is useful.

could you do the check that all steps have been used in dry_run mode
instead of when running the tests for real?

--
Melanie Plageman

pgsql-hackers by date:

Previous
From: Joe Conway
Date:
Subject: Re: [Proposal] Table-level Transparent Data Encryption (TDE) and KeyManagement Service (KMS)
Next
From: Dmitry Dolgov
Date:
Subject: io_uring support