Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) - Mailing list pgsql-hackers

From Melanie Plageman
Subject Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)
Date
Msg-id CAAKRu_aoK6824z_JtJUWMZk2ST2dXN005Gkt05iitTLD2i4OCw@mail.gmail.com
Whole thread
In response to Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)  (Alexander Lakhin <exclusion@gmail.com>)
Responses Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)
List pgsql-hackers
On Sat, Apr 18, 2026 at 2:00 PM Alexander Lakhin <exclusion@gmail.com> wrote:
>
> 18.04.2026 19:25, Andres Freund wrote:
>
> >> Could you please look if this can be fixed?
> > When you say fix, I assume you mean address the test instability, rather than
> > actual code changes?
>
> Sure, I didn't mean the new behavior is wrong. Probably changing that
> table to temporary would work

Yes, I think changing it to a temp table is the easiest fix. We could
also do autovacuum_enabled=false, I think, but making it a temp table
seems cleanest.

I wonder if we should move the EXPLAIN test above the results queries,
then throw in a vacuum in between some of them so we exercise btree
gist as a bitmap heap scan and as an index only scan. It could provide
a little bit more coverage? Or maybe that isn't actually extra
coverage. I'm not sure.

> but I wonder if there are other queries,
> which plans can change due to the same reason.

I think we'll have to take this on a case-by-case basis when we see
failures. While it is certainly possible other tests just rely on
autovacuum not having run and set the page all-visible, many of them
probably have already had to account for that.

- Melanie



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: First draft of PG 19 release notes
Next
From: Alvaro Herrera
Date:
Subject: Re: Adding REPACK [concurrently]