Thanks for the review!
On Tue, Nov 18, 2025 at 9:10 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
> > On Nov 19, 2025, at 10:00, Chao Li <li.evan.chao@gmail.com> wrote:
>
> > I just reviewed 0007. It removes the second parameter "bool skip_recently_used” from SyncOneBuffer. The function
isstatic and is only called in one place with skip_recently_used=true, thus removing the parameter seems reasonable,
andwithout considering pinned buffer, the function is simplified a little bit.
> >
> > I only got a tiny comment:
> > ```
> > + * We can make these check without taking the buffer content lock so
> > ```
> >
> > As you changed “this” to “these”, “check” should be changed to “checks” accordingly.
I've made this change. Attached v10 has this.
> I just got an compile error:
> ```
> bufmgr.c:3580:33: error: no member named 'dbId' in 'struct CkptSortItem'
> 3580 | batch.rlocator.dbOid = item.dbId;
> | ~~~~ ^
> bufmgr.c:3598:13: error: no member named 'dbId' in 'struct CkptSortItem'
> 3598 | if (item.dbId != batch.rlocator.dbOid)
> | ~~~~ ^
> 2 errors generated.
> make[4]: *** [bufmgr.o] Error 1
> ```
>
> I tried “make clean” and “make” again, which didn’t work. I think the error is introduced by 0006.
Are you sure you applied 0005? It is the one that adds dbId to CkptSortItem.
- Melanie
