Request a Demo
Home   >   mailing lists

Re: Buffer locking is special (hints, checksums, AIO writes) - Mailing list pgsql-hackers

From Melanie Plageman
Subject Re: Buffer locking is special (hints, checksums, AIO writes)
Date
Msg-id CAAKRu_Z9BzF=mHeiy+tUJ524_c7q0sBabschMX83Shag2XohpA@mail.gmail.com
Whole thread Raw
In response to Re: Buffer locking is special (hints, checksums, AIO writes)  (Andres Freund <andres@anarazel.de>)
Responses Re: Buffer locking is special (hints, checksums, AIO writes)
List pgsql-hackers
Tree view 
On Mon, Nov 24, 2025 at 3:58 PM Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> On 2025-11-19 21:47:49 -0500, Andres Freund wrote:
> > 0001: A straight-up bugfix in lwlock.c - albeit for a bug that seems currently
> >       effectively harmless.
>
> Does anybody have opinions about whether to backpatch this fix? Given that it
> has no real consequences I'm mildly inclined not to, but maybe there are cases
> where the additional wait list lock cycle matters?

Since it is a mistake, I am mildly in favor of backporting to avoid
confusion for future developers. It's pretty weird that LWLockWakeup()
has to be called again to actually unset LW_FLAG_HAS_WAITERS. But
since it's not really harmful, this is a very mild opinion.

- Melanie

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent
Next
From: Tom Lane
Date:
Subject: Re: Add notification on BEGIN ATOMIC SQL functions using temp relations