On Thu, Nov 20, 2025 at 12:55 PM Dagfinn Ilmari Mannsåker
<ilmari@ilmari.org> wrote:
>
> I didn't pay much attention to this thread, so I didn't notice this
> until it got committed, but I'd like to lodge an objection to this
> formatting, especially the lack of spaces before the field names. This
> would be much more readable with one struct field per line, i.e.
>
> PruneFreezeParams params = {
> .relation = rel,
> .buffer = buf,
> .reason = PRUNE_VACUUM_SCAN,
> .options = HEAP_PAGE_PRUNE_FREEZE,
> .vistest = vacrel->vistest,
> .cutoffs = &vacrel->cutoffs,
> };
>
> or at a pinch, if we're really being stingy with the vertical space:
>
> PruneFreezeParams params = {
> .relation = rel, .buffer = buf,
> .reason = PRUNE_VACUUM_SCAN, .options = HEAP_PAGE_PRUNE_FREEZE,
> .vistest = vacrel->vistest, .cutoffs = &vacrel->cutoffs,
> };
>
> I had a quick grep, and every other designated struct initialiser I
> could find uses the one-field-per-line form, but they're not consistent
> about the comma after the last field. I personally prefer having it, so
> that one can add more fields later without having to modify the
> unrelated line.
pgindent doesn't allow for a space after the comma before the period.
One reason I used struct initialization was to save space, so I'm a
bit loath to put every member on its own line. However, I don't want
to make the code less readable to others. So, I will commit an update
as you request.
- Melanie
