PrepareTempTablespaces is called by most callers of BufFileCreateTemp, so I was wondering if there is a reason not to call it inside BufFileCreateTemp.
As a developer using BufFileCreateTemp to write code that will create spill files, it was easy to forget the extra step of checking the temp_tablespaces GUC to ensure I create the spill files there if it is set.
