Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Improve catcache/syscache performance. - Mailing list pgsql-hackers

From amul sul
Subject Re: [HACKERS] Improve catcache/syscache performance.
Date
Msg-id CAAJ_b97qe-djtnrMb6O-K0Q7ebtpGSWEXxLZ-2vSvby_K44CxQ@mail.gmail.com
Whole thread Raw
In response to [HACKERS] Improve catcache/syscache performance.  (Andres Freund <andres@anarazel.de>)
Responses Re: [HACKERS] Improve catcache/syscache performance.
List pgsql-hackers
Tree view
Patch 0007:

1: 
400 +       /*
401 +        * XXX: might be worthwhile to only handle oid sysattr, to reduce
402 +        * overhead - it's the most common key.
403 +        */

IMHO, let fix that as well. I tested this by fixing (see the attach patch) but does
not found much gain on my local centos vm (of course, the pgbench load
wasn't big enough).

2:  How about have wrapping following condition in SearchCatCacheMiss() by unlikely(): 

if (IsBootstrapProcessingMode())
            return NULL;

3: Can we have following assert in SearchCatCacheN() instead SearchSysCacheN(), so that we'll assert direct SearchCatCacheN() call as well?

Assert(SysCache[cacheId]->cc_nkeys == <N>);

Other than these concern, patch looks pretty reasonable to me. 

Regards,
Amul
Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: [HACKERS] Partition-wise join for join between (declaratively)partitioned tables
Next
From: Fabien COELHO
Date:
Subject: Re: [HACKERS] psql - add ability to test whether a variable exists