Re: Exclude pg_largeobject form pg_dump - Mailing list pgsql-general

From amul sul
Subject Re: Exclude pg_largeobject form pg_dump
Date
Msg-id CAAJ_b979qaRa-UyOoeDE7iP0mHa5e3hRDJrXQWm6FHoZvAXEaQ@mail.gmail.com
Whole thread Raw
In response to Re: Exclude pg_largeobject form pg_dump  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: Exclude pg_largeobject form pg_dump
List pgsql-general
Hi Guillaume,

I found following issues with this patch, sorry missed in previous post:

#1 :
 43 @@ -392,6 +393,10 @@ main(int argc, char **argv)
 44                 dopt.outputBlobs = true;
 45                 break;
 46
 47 +           case 'B':           /* Don't dump blobs */
 48 +               dopt.include_everything = false;
 49 +               break;
 50 +

Touching dopt.include_everything flag does not seems to be a good idea
for '--no-blobs' option, our intension is to exclude blob only, but
this excluds other dump too (e.g COMMENT ON DATABASE, CREATE
EXTENSION, COMMENT ON EXTENSION, .., etc)  that what we don't want,
right?

#2 :
We should add note for default behaviour if --no-blobs & --blobs both
are specified.

Regards,
Amul Sul


pgsql-general by date:

Previous
From: David Steele
Date:
Subject: Re: WAL segmentes names in wrong order?
Next
From: Guillaume Lelarge
Date:
Subject: Re: Exclude pg_largeobject form pg_dump