Re: Deduplicate code updating ControleFile's DBState. - Mailing list pgsql-hackers

From Amul Sul
Subject Re: Deduplicate code updating ControleFile's DBState.
Date
Msg-id CAAJ_b96B_AHfD2-=fPiny0Hfeh62bQa7aFJe63K7vfcbeHMT+A@mail.gmail.com
Whole thread Raw
In response to Re: Deduplicate code updating ControleFile's DBState.  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Mon, Nov 29, 2021 at 10:12 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, Nov 29, 2021 at 09:28:23AM +0530, Bharath Rupireddy wrote:
> > In that case, why can't we inline UpdateControlFile to avoid the
> > function call cost? Do you see any issues with it?
>
> This routine is IMO not something worth bothering about.
>
> > BTW, the v6 patch proposed by Amul at [1], looks good to me.
>
> Yes, I have no problems with this part, so done.

Thank you, Michael.

Regards,
Amul



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: row filtering for logical replication
Next
From: Amul Sul
Date:
Subject: tweak to a few index tests to hits ambuildempty() routine.