Request a Demo
Home   >   mailing lists

Re: Minor refactor of the code in ExecScanExtended() - Mailing list pgsql-hackers

From Henson Choi
Subject Re: Minor refactor of the code in ExecScanExtended()
Date
Msg-id CAAAe_zDyq-Yg-xL8FSNaeneSXmesFs6JefxNJo2coQQjP3RLcQ@mail.gmail.com
Whole thread Raw
In response to Re: Minor refactor of the code in ExecScanExtended()  (Aditya Gollamudi <adigollamudi@gmail.com>)
List pgsql-hackers
Tree view
Hi hackers,

2026년 1월 19일 (월) PM 1:51, Aditya Gollamudi <adigollamudi@gmail.com>님이 작성:
On Sun, Jan 18, 2026 at 7:31 PM cca5507 <cca5507@qq.com> wrote:
Hi,

The current code:

      if (!qual && !projInfo)
      {
            ResetExprContext(econtext);
            return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);
      }

      ResetExprContext(econtext);

The following format might be simpler:

      ResetExprContext(econtext);

      if (!qual && !projInfo)
            return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);

Attach a patch to do this.

--
Regards,
ChangAo Chen

Hi, 

+1, seems like a simple refactor. 
Tests are passing locally for me!

- Adi Gollamudi 


The refactored version is cleaner and easier to read by moving
ResetExprContext() before the early return,
eliminating the duplicated logic.

Best regards,
Henson

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: raise ERROR between EndPrepare and PostPrepare_Locks causes ROLLBACK 2pc PAINC
Next
From: Chao Li
Date:
Subject: Re: VACUUM FULL, CLUSTER, and REPACK block on other sessions' temp tables