> I'm now reviewing the remaining parts: pattern optimization in planner, > absorption function, and step function. Once the review is complete, > I'll send the rest of the patches.
I am reviewing the test cases and found this:
SELECT * FROM (SELECT 1 AS x) t WINDOW w AS ( ROWS BETWEEN CURRENT ROW AND UNBOUNDED FOLLOWING PATTERN (a b c d e f g h i j k l m n o p q r s t u v w x y z aa) DEFINE a AS TRUE ); ERROR: number of row pattern definition variable names exceeds 26
I thought you have eliminated the 26 variables limit. If so, related codes using WindowClause->defineInitial should be removed. Shall I do that? Or you want to do that while refactoring?
Already found and cleaned up. Will include it in the next patch.
