Hi Tatsuo,
Thanks for the 2015-2026 review. Just the three you flagged:
> ... it will make it hard to call the function from R010
> implementation because MATCH_RECOGNIZE node surely will not have
> WindowClause node.
Agreed -- reusability for R010 matters more. I'll keep the explicit
arguments rather than the WindowClause and revise 2016 so
buildRPRPattern() just walks defineClause for the DEFINE names.
> I think we should not include following patch in our patch set. That
> has nothing to do with RPR.
You're right, it doesn't belong with RPR. I'll remove the two
follow-up commits and drop it from 2019.
> There's no instance in PostgreSQL code which uses
> pg_attribute_unused() with function arguments for debugging purpose.
OK. I will remove the pg_attribute_unused().
Best regards,
Henson
