Re: [PATCH] rewriteGraphTable: Fix missing RTEs in FROM clause by setting inFromCl=true - Mailing list pgsql-hackers

From Henson Choi
Subject Re: [PATCH] rewriteGraphTable: Fix missing RTEs in FROM clause by setting inFromCl=true
Date
Msg-id CAAAe_zCOGCXvj4c=B=Swi6M8POCFb2SdJm1xkJkNi3NOLTL5Yw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] rewriteGraphTable: Fix missing RTEs in FROM clause by setting inFromCl=true  (Junwang Zhao <zhjwpku@gmail.com>)
Responses Re: [PATCH] rewriteGraphTable: Fix missing RTEs in FROM clause by setting inFromCl=true
List pgsql-hackers
Hi Man,

I checked the comment:

* inFromCl marks those range variables that are listed in the FROM clause.
* It's false for RTEs that are added to a query behind the scenes, such
* as the NEW and OLD variables for a rule, or the subqueries of a UNION.

Even the RTEs are not directly listed in FROM, but as we are rewriting the
match pattern using join and where clause, I tend to agree with the fix.

 Would you consider adding this to the commitfest?

Best regards,
Henson

pgsql-hackers by date:

Previous
From: lakshmi
Date:
Subject: Re: Avoid multiple calls to memcpy (src/backend/access/index/genam.c)
Next
From: Evgeny Voropaev
Date:
Subject: Re: Compress prune/freeze records with Delta Frame of Reference algorithm