Request a Demo
Home   >   mailing lists

Re: Row pattern recognition - Mailing list pgsql-hackers

From Henson Choi
Subject Re: Row pattern recognition
Date
Msg-id CAAAe_zAhXuBTRiNVU1RrJKOiKoyeu-pgYaYb8HaqbhSsC=sGUg@mail.gmail.com
Whole thread
In response to Re: Row pattern recognition  (Tatsuo Ishii <ishii@postgresql.org>)
Responses Re: Row pattern recognition
List pgsql-hackers
Tree view
Hi Tatsuo, Jian,

Both coding-style items from Jian's review will be addressed and
included in the next patch series.

> 1. We need to add trailing commas to enum definitions. See
> https://git.postgresql.org/cgit/postgresql.git/commit/?id=611806cd726fc92989ac918eac48fd8d684869c7

I forgot that. Thanks for reminding.

Three enum types introduced by the patch lack a trailing comma on the
last enumerator: RPRNavKind, RPRNavOffsetKind, and RPRPatternNodeType.
All three will be corrected in the next series.
 
> + (errcode(ERRCODE_SYNTAX_ERROR),
> The leading parenthesis is optional and can be removed, fewer
> parentheses are always better.
> See related discussion:
> https://postgr.es/m/202510100916.s2e6n3xiwvyc@alvherre.pgsql

Right. I will review all other patches.

The outer-parentheses pattern appears in 17 ereport() calls in
parse_rpr.c and 2 in optimizer/plan/rpr.c.  All 19 sites will be
cleaned up in the next series.

Jian, I will review your other patches as well.

Best,
Henson

pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: [PATCH] Fix ProcKill lock-group vs procLatch recycle race
Next
From: Tatsuo Ishii
Date:
Subject: Re: Row pattern recognition