Hi Tatsuo,
> BTW, in create_windowagg_plan (createplan.c),
> around:
> /* Build RPR pattern and filter defineClause */
>
> collectPatternVariables, filterDefineClause and buildRPRPattern are
> called in a block without any if or any other conditional
> statements. This is an unusual codiing style in PostgreSQL. I suggest
> to fix this. Attached is a proposed patch for this.
Good catch, thank you! I've renumbered your patch as nocfbot-0007
and extended the same cleanup to rpr.c and parse_rpr.c as
nocfbot-0008.
nocfbot-0007: Refactor create_windowagg_plan to remove bare
variable-scoping block (your patch, renumbered)
nocfbot-0008: Remove bare variable-scoping blocks in RPR code
Applies the same cleanup to rpr.c and parse_rpr.c, with minor
pgindent formatting fixes.
I'll keep this coding style point in mind for future code as well.
Best regards,
Henson
