Hi Tatsuo,
Thanks for rebasing to v43!
I noticed the Cirrus CI 32-bit build (test_world_32) failed on three
tests, all due to the same root cause in rpr_explain.out:
Sort Method: quicksort Memory: 27kB (expected, 64-bit)
Sort Method: quicksort Memory: 22kB (actual, 32-bit)
The rpr_explain_filter() function was already normalizing the RPR
Storage memory values, but missed the Sort node's "Memory: NNkB"
which also varies between 32-bit and 64-bit due to pointer/struct
size differences.
The attached incremental patch adds Sort Method memory normalization
to rpr_explain_filter(), using the same approach as the existing
Storage and Maximum Storage filters.
> The node serialization functions (141 lines, 0% coverage) are the
> largest untested area. I'm not sure how to trigger these paths
> in the regression test framework. Any suggestions?
I think we can leave it as it is, until reluctant quantifier is
implemented.
Agreed.
> I'll send a separate email within a few days listing the FIXME
> issues and other unresolved items from the mailing list discussion
> for your review.
Looking forward to reading your email.
Best regards,
Henson
