improve comments on CreateFunction returnsSet - Mailing list pgsql-hackers

From Zshengbin91
Subject improve comments on CreateFunction returnsSet
Date
Msg-id CAA9n-n65zXceL-zD-v9S_ADuUrYagO6gotfob1pOMQjS5f-FGA@mail.gmail.com
Whole thread Raw
List pgsql-hackers
Hi hackers,

I'm using postgres, and I found a potentially ambiguous code comment in the `CreateFunction` function. `returnsSet` is a boolean variable, and to be consistent with the subsequent error message, I believe the comment should be modified to match the error message. "reject ROWS if it's not returnsSet" should be changed to "reject ROWS if it does not return a set"  Therefore, I've attached a patch to address this issue.

Thanks!
Br/Shengbin Zhao

Attachment

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Switch buffile.c/h to use pgoff_t
Next
From: Chao Li
Date:
Subject: Trivial Fix: use palloc_array/repalloc_array for BufFile file arrays