Re: [DOC] Update ALTER SUBSCRIPTION documentation v3 - Mailing list pgsql-hackers

From Robert Sjöblom
Subject Re: [DOC] Update ALTER SUBSCRIPTION documentation v3
Date
Msg-id CAA96TE03GC2v2Kon=83rZCqCNAyCRiKB8TtmqNt041oKTGWTeA@mail.gmail.com
Whole thread Raw
In response to Re: [DOC] Update ALTER SUBSCRIPTION documentation v3  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: [DOC] Update ALTER SUBSCRIPTION documentation v3
List pgsql-hackers
Den ons 17 maj 2023 kl 03:18 skrev Peter Smith <smithpb2250@gmail.com>:
>
> + errhint("Use %s to disassociate the subscription from the slot after
> disabling the subscription.",
>
> IMO it looked strange having the word "subscription" 2x in the same sentence.
>
> Maybe you can reword the errhint like:
>
> BEFORE
> "Use %s to disassociate the subscription from the slot after disabling
> the subscription."
>
> SUGGESTION#1
> "Disable the subscription, then use %s to disassociate it from the slot."
>
> SUGGESTION#2
> "After disabling the subscription use %s to disassociate it from the slot."
>
> ~~~
>
> BTW, it is a bit difficult to follow this thread because the subject
> keeps changing.
>
> ------
> Kind Regards,
> Peter Smith.
> Fujitsu Australia

Good catch, I definitely agree. I'm sorry about changing the subject
line, I'm unaccustomed to mailing lists -- I'll leave it as it is now.

Attached is the revised version.

Best regards,
Robert Sjöblom

--
Innehållet i detta e-postmeddelande är konfidentiellt och avsett endast för
adressaten.Varje spridning, kopiering eller utnyttjande av innehållet är
förbjuden utan tillåtelse av avsändaren. Om detta meddelande av misstag
gått till fel adressat vänligen radera det ursprungliga meddelandet och
underrätta avsändaren via e-post

Attachment

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Order changes in PG16 since ICU introduction
Next
From: Michael Paquier
Date:
Subject: Re: Conflict between regression tests namespace & transactions due to recent changes