Postgres Pro
Downloads
Home   >   mailing lists

Re: ALTER TABLE ADD COLUMN fast default - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: ALTER TABLE ADD COLUMN fast default
Date
Msg-id CAA8=A7-QDj7ngk3XBe4F516JRqpFFcN=yv0_gCLCNJ_MkdMM-w@mail.gmail.com
Whole thread Raw
In response to Re: ALTER TABLE ADD COLUMN fast default  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: ALTER TABLE ADD COLUMN fast default  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On Sun, Feb 18, 2018 at 2:52 PM, David Rowley
<david.rowley@2ndquadrant.com> wrote:
> On 17 February 2018 at 10:46, Andrew Dunstan
> <andrew.dunstan@2ndquadrant.com> wrote:
>> The attached version largely fixes with the performance degradation
>> that Tomas Vondra reported, replacing an O(N^2) piece of code in
>> slot_getmissingattrs() by one that is O(N).
>
> I've looked over this patch and had a play around with it.
>
> Just a couple of things that I noticed while reading:
>

[ various typos ]

>
> I'll try to spend some time reviewing the code in detail soon.
>


Thanks. I'll fix the typos in the next version of the patch, hopefully
after your review.

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Patrick Krecker
Date:
Subject: Re: TODO item: WAL replay of CREATE TABLESPACE with differingdirectory structure
Next
From: Tomas Vondra
Date:
Subject: Re: [HACKERS] Removing [Merge]Append nodes which contain a singlesubpath