Re: Add mode column to pg_stat_progress_vacuum - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: Add mode column to pg_stat_progress_vacuum
Date
Msg-id CAA5RZ0vMDwuTKyxwLkBZC_5UvjknxvsYCqcRrtRcV6+v=BFyfg@mail.gmail.com
Whole thread Raw
In response to Re: Add mode column to pg_stat_progress_vacuum  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: Add mode column to pg_stat_progress_vacuum
List pgsql-hackers
I am bit late to this thread, but I have a comment.

> This patch introduces a mode column to provide this visibility. The
> possible values are:
> - normal: A standard, user-initiated VACUUM or a regular autovacuum run.
> - anti-wraparound: An autovacuum run launched specifically to prevent
> transaction ID wraparound.
> - failsafe: A vacuum that has entered failsafe mode to prevent
> imminent transaction ID wraparound.

The vacuum command detail can now be determined from
pg_stat_activity.query by joining with pg_stat_progress_vacuum, right?
I don't see why this is not sufficient, especially because it already
indicates how the vacuum was triggered, and the autovacuum activity
message also tells you why it was triggered. We could perhaps add "due to
failsafe" to the autovacuum activity message to explicitly show that reason.

--
Sami Imseih
Amazon Web Services (AWS)



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Add memory_limit_hits to pg_stat_replication_slots
Next
From: Masahiko Sawada
Date:
Subject: Re: Invalid pointer access in logical decoding after error