Re: Add missing CHECK_FOR_INTERRUPTS in autovacuum catalog scan loops - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: Add missing CHECK_FOR_INTERRUPTS in autovacuum catalog scan loops
Date
Msg-id CAA5RZ0vCoWBmhKhoi3BKjn7SAkOsYUuO2y=iSh4sSn0q0BYS9Q@mail.gmail.com
Whole thread Raw
In response to Re: Add missing CHECK_FOR_INTERRUPTS in autovacuum catalog scan loops  (Dapeng Wang <wangdp20191008@gmail.com>)
List pgsql-hackers
Hi,

It was discussed [1] here if C_F_I is needed in these
do_autovacuum/autovacuum_scores code paths, and it
was decided not to add them.

Also, at least on my tests with 100k evern with 1 million tables, I did
not see a reason to do so. These are catalog scans that should
happen quick enough, even in extreme cases, to not make
this worthwhile.

Others may have another opinion.

--
Sami


[1] [https://www.postgresql.org/message-id/acwTxpz3Toxt0ty8%40nathan]



pgsql-hackers by date:

Previous
From: Shlok Kyal
Date:
Subject: Re: Support EXCEPT for ALL SEQUENCES publications
Next
From: David Rowley
Date:
Subject: StringInfo fixes, v19 edition. Plus a few oddities