Re: test_autovacuum/001_parallel_autovacuum is broken - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: test_autovacuum/001_parallel_autovacuum is broken
Date
Msg-id CAA5RZ0uqvjxv5HPzz36UEq-LUf8F+kae61k0imaGw0C0XGa7nw@mail.gmail.com
Whole thread Raw
In response to Re: test_autovacuum/001_parallel_autovacuum is broken  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: test_autovacuum/001_parallel_autovacuum is broken
Re: test_autovacuum/001_parallel_autovacuum is broken
List pgsql-hackers
> The root cause seems to me that it's not guaranteed that we can see
> the autovacuum logs after checking the statistics (i.e.,
> pg_stat_user_tables) as we update the statistics and then write the
> log.
>
> One way to fix the test is to replace log_contains() with
> wait_for_log(). We can also remove wait_for_autovacuum_complete()
> logic altogether.

+1. I was going to reply with exactly this. Attached is the fix.

--
Sami

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: test_autovacuum/001_parallel_autovacuum is broken
Next
From: Masahiko Sawada
Date:
Subject: Re: POC: Parallel processing of indexes in autovacuum