Re: n_ins_since_vacuum stats for aborted transactions - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: n_ins_since_vacuum stats for aborted transactions
Date
Msg-id CAA5RZ0upB-TYCxqpbidgbHMSm_v0GHh39AQDUQmrdohpW6YDsQ@mail.gmail.com
Whole thread Raw
In response to Re: n_ins_since_vacuum stats for aborted transactions  ("David G. Johnston" <david.g.johnston@gmail.com>)
Responses Re: n_ins_since_vacuum stats for aborted transactions
Re: n_ins_since_vacuum stats for aborted transactions
List pgsql-hackers
> Forget original purpose, is there presently a bug or not?

Yes, there is a bug. Accounting rows inserted as part of an aborted
transaction in
n_ins_since_vacuum is not correct, since the same rows are being
accounted for with n_dead_tup.

> Between the two options the one where we count dead tuples makes more sense on its face.

IIUC, I am saying the same thing, if an inserted row is rolled back,
it should only count as a
dead tuple (n_dead_tup) only, and not in n_ins_since_vacuum.

--
Sami Imseih
Amazon Web Services (AWS)



pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: n_ins_since_vacuum stats for aborted transactions
Next
From: Bertrand Drouvot
Date:
Subject: Re: Draft for basic NUMA observability