Re: pgsql: Trial fix for old cross-version upgrades. - Mailing list pgsql-committers

From Sami Imseih
Subject Re: pgsql: Trial fix for old cross-version upgrades.
Date
Msg-id CAA5RZ0tz-AibaxVF1NnNMcMEmwut+kn=k=xG2XmDN9d6kv2-=g@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Trial fix for old cross-version upgrades.  (Sami Imseih <samimseih@gmail.com>)
Responses Re: pgsql: Trial fix for old cross-version upgrades.
List pgsql-committers
My perl expertise is bit shallow, but I could not find much
regarding bugs related to such behavior, or maybe I did not
look enough.

Playing around with this, "s+", "s{1,}", s{2,}" all of these combinations
where we are searching for more than 1 space result in the hanging command,
but we really only need to look for a single space before the 'version',
so maybe we can just do the below, which works?

-       $dump =~ s {(^\s+'version',) '\d+'::integer,$}
+      $dump =~ s {(^\s{1}'version',) '\d+'::integer,$}

-- 
Sami



pgsql-committers by date:

Previous
From: Sami Imseih
Date:
Subject: Re: pgsql: Trial fix for old cross-version upgrades.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Trial fix for old cross-version upgrades.