Re: Add support for entry counting in pgstats - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: Add support for entry counting in pgstats
Date
Msg-id CAA5RZ0tup7ofJRg-8_PiexBC0dLeMntcw5akvU_15Qj1AVk5yQ@mail.gmail.com
Whole thread Raw
In response to Re: Add support for entry counting in pgstats  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Thanks for v3. The only remaining comment I have is:

This comment seems unnecessary, since refcount is not checked inside
pgstat_free_entry, but earlier.

+       /*
+        * Entry has been dropped with refcount at 0, hence decrement the
+        * entry counter.
+        */

I would just say this,

/* Decrement entry count, if required. */

--
Sami



pgsql-hackers by date:

Previous
From: David Christensen
Date:
Subject: Re: [PATCH] GROUP BY ALL
Next
From: Robert Treat
Date:
Subject: Re: Adding REPACK [concurrently]