Re: [PATCH] pg_stat_statements: add last_execution_start column - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: [PATCH] pg_stat_statements: add last_execution_start column
Date
Msg-id CAA5RZ0tMEN_wo=WCT6erJ9t6d62Rh+K4w+8ofpjPrBS+-18WxQ@mail.gmail.com
Whole thread
In response to [PATCH] pg_stat_statements: add last_execution_start column  ("Pavlo Golub" <pavlo.golub@cybertec.at>)
Responses Re[2]: [PATCH] pg_stat_statements: add last_execution_start column
List pgsql-hackers
Hi,

It would be really great to get this field in, but I think the current
implementation still suffers from the same issue that is mentioned
here [1]. We cannot rely on GetCurrentStatementStartTimestamp()
in-line because ExecutorEnd is deferred to the next execution in the
case of extended query protocol. I think we need to add it to track the
start timestamp in queryDesc. What do you think?

```
select pg_stat_statements_reset();

BEGIN;
select now() as now, clock_timestamp() as clock_timestamp,
pg_sleep($1) \bind 10 \g

\! sleep 10

SELECT now() as now, clock_timestamp() as clock_timestamp, $1 \bind 1 \g
END;

select last_execution_start, total_exec_time, substr(query, 1, 150) as
query from pg_stat_statements;
```
Notice how the last_execution_start reflects when the
"SELECT now() as now, clock_timestamp() as clock_timestamp, $1 " runs

--
Sami

[1] [https://www.postgresql.org/message-id/CAA5RZ0sxPWP2xm8fxhscE%2BcUqC2VSFi9UZ9882BdGZ0MbGQNUA%40mail.gmail.com]



pgsql-hackers by date:

Previous
From: Zsolt Parragi
Date:
Subject: Re: Patch: dumping tables data in multiple chunks in pg_dump
Next
From: Jacob Champion
Date:
Subject: Re: Make PGOAUTHCAFILE in libpq-oauth work out of debug mode