Re: Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements
Date
Msg-id CAA5RZ0tH_+3JGMCktkp8EMyvKaRAJf-xRh+y_UoZ8azvuUEAYQ@mail.gmail.com
Whole thread Raw
In response to Re: Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements  (Christoph Berg <myon@debian.org>)
Responses Re: Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements
List pgsql-hackers
> > I wonder if we can use GetCurrentStatementStartTimestamp()
> > instead?
>
> The main use case for this column is being able to retrieve the stats
> that were updated since the last time one was looking. That only works
> if it's the statement end time, or else long-running statements
> spanning more than one poll interval would be missed.

Sure, I get it is not perfect for the polling use-case due to the scenario
you mention,  but I don't think it will be acceptable to call
GetCurrentTimeStamp() at the end of every execution and especially
with a SpinLock held.

This will probably be worse for nested_tacking as well, due to
multiple GetCurrentTimeStamp() calls.

What do you think?

--
Sami Imseih
Amazon Web Services (AWS)



pgsql-hackers by date:

Previous
From: wangpeng
Date:
Subject: Re: pg_dumpall --roles-only interact with other options
Next
From: Zane Duffield
Date:
Subject: Proposal: pg_createsubscriber use without superuser privileges