Re: doc: fix pg_stat_autovacuum_scores threshold wording - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: doc: fix pg_stat_autovacuum_scores threshold wording
Date
Msg-id CAA5RZ0sndnZhap8f_BNxTi04nFTeA9UV6akp-Jy0mbVg2qu5cQ@mail.gmail.com
Whole thread
In response to Re: doc: fix pg_stat_autovacuum_scores threshold wording  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: doc: fix pg_stat_autovacuum_scores threshold wording
List pgsql-hackers
> I guess that may be how the current wording came from. But it seems a bit indirect to describe it that way, because
theweight itself does not determine if autovacuum would vacuum or analyze the table.
 
>
> Rewriting the doc more broadly would be a larger change. This small patch is only meant to avoid the confusion shown
bythe test earlier, where the score is equal to the weight but do_vacuum is false.
 

Hi,

Thanks for reporting. I took a look and agree with your doc changes.
do_vacuum/do_analyze will not be true for cases where the
individual component scores are less than or equal to the weight.

The patch LGTM

--
Sami Imseih
Amazon Web Services (AWS)



pgsql-hackers by date:

Previous
From: Baji Shaik
Date:
Subject: Re: [PATCH] COPY TO FORMAT json: respect column list order
Next
From: Bharath Rupireddy
Date:
Subject: Re: [PATCH] Check dead heap items before marking them unused