pg_plan_advice: rtekind uninitialized compilation waning - Mailing list pgsql-hackers

From Sami Imseih
Subject pg_plan_advice: rtekind uninitialized compilation waning
Date
Msg-id CAA5RZ0sieVNfniCKMDdDjuXGd1OuzMQfTS5=9vX3sa-iiujKUA@mail.gmail.com
Whole thread
Responses Re: pg_plan_advice: rtekind uninitialized compilation waning
List pgsql-hackers
Hi,

I just noticed $SUBJECT due to 5883ff30b0

[1/2] Compiling C object
contrib/pg_plan_advice/pg_plan_advice.so.p/pgpa_scan.c.o
In file included from ../src/include/postgres.h:49:0,
                 from ../contrib/pg_plan_advice/pgpa_scan.c:12:
../contrib/pg_plan_advice/pgpa_scan.c: In function ‘unique_nonjoin_rtekind’:
../src/include/utils/elog.h:241:18: warning: ‘rtekind’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
  ereport(elevel, errmsg_internal(__VA_ARGS__))
                  ^~~~~~~~~~~~~~~
../contrib/pg_plan_advice/pgpa_scan.c:246:11: note: ‘rtekind’ was declared here
  RTEKind  rtekind;
           ^~~~~~~

Attached initializes rtekind to RTE_RELATION to keep the compiler happy.
The value is set correctly inside the loop before it's used.


--
Sami Imseih
Amazon Web Services (AWS)

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Better shared data structure management and resizable shared data structures
Next
From: Corey Huinker
Date:
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump