Re: Fix bug in multixact Oldest*MXactId initialization and access - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: Fix bug in multixact Oldest*MXactId initialization and access
Date
Msg-id CAA5RZ0s+rr=DVkFnMwupgnCAvPjJkjQ3jr5=7X_=Sb5Mr02-Mg@mail.gmail.com
Whole thread
In response to Re: Fix bug in multixact Oldest*MXactId initialization and access  (Yura Sokolov <y.sokolov@postgrespro.ru>)
Responses Re: Fix bug in multixact Oldest*MXactId initialization and access
List pgsql-hackers
> (Sorry, I've used Google Translate to write this sentence).
>
> When you write assert, you protect yourself from shooting your leg far in
> the future. Believe me.

The issue to me seems that we a few code paths that rely on the
total proc calculation in several places, and changing one and
forgetting to change another is what broke things. I am all for
future proofing this, and I think simply centralizing the calculation
should be enough without adding complexity to the code.

Maybe others have a different opinion.

--
Sami Imseih
Amazon Web Services (AWS)



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Unicode update and some tooling improvements
Next
From: Madhav Madhusoodanan
Date:
Subject: Re: [WiP] B-tree page merge during vacuum to reduce index bloat