Request a Demo
Home   >   mailing lists

Re: [PATCH v1] replindex: Fix comment grammar in build_replindex_scan_key() - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [PATCH v1] replindex: Fix comment grammar in build_replindex_scan_key()
Date
Msg-id CAA4eK1LocMpXac_XVikYOhPyC=nC01phLU+WXO+j9UNjsp-AfQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH v1] replindex: Fix comment grammar in build_replindex_scan_key()  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
Tree view 
On Tue, Dec 30, 2025 at 4:04 AM Chao Li <li.evan.chao@gmail.com> wrote:
> > On Dec 29, 2025, at 16:20, zourenli <398740848@qq.com> wrote:
> >
> > <v1-0001-corrects-minor-grammatical-issues-in-comment-of-b.patch>
>
> Both fixes look unambiguously correct to me:
>
>     • “This is not generic routine” -> “This is not a generic routine”
>     • “used for REPLICA IDENTITY FULL table” -> “used for a REPLICA IDENTITY FULL table”
>

LGTM.

--
With Regards,
Amit Kapila.

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Wrong comment for ReplicationSlotCreate
Next
From: jian he
Date:
Subject: Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions